Skip to content

chore(Banner): Move Banner CSS module flag from staff to ga #5225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2024
Merged

chore(Banner): Move Banner CSS module flag from staff to ga #5225

merged 2 commits into from
Nov 5, 2024

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 4, 2024 •
edited by siddharthkp
Loading

Changelog

New

Changed

Move Banner CSS module flag from staff to ga

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 99ba236

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5225 November 4, 2024 19:46 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.48 KB (0%)
packages/react/dist/browser.umd.js 98.91 KB (0%)

@jonrohan jonrohan marked this pull request as ready for review November 4, 2024 23:25
@jonrohan jonrohan requested a review from a team as a code owner November 4, 2024 23:25
@jonrohan jonrohan requested a review from siddharthkp November 4, 2024 23:25
@jonrohan jonrohan enabled auto-merge November 4, 2024 23:25
siddharthkp
siddharthkp approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@jonrohan jonrohan added this pull request to the merge queue Nov 5, 2024
@siddharthkp siddharthkp added integration-tests: skipped manually Changes in this PR do not require an integration test and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 5, 2024
Merged via the queue into main with commit e732591 Nov 5, 2024
48 of 49 checks passed
@jonrohan jonrohan deleted the move_css_module_flag_banner branch November 5, 2024 15:11
@primer primer bot mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees

No one assigned

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @siddharthkp