Skip to content

feat(ButtonBase): Remove css modules feature flag from ButtonBase #5222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 6, 2024
Merged

feat(ButtonBase): Remove css modules feature flag from ButtonBase #5222

merged 6 commits into from
Dec 6, 2024

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 4, 2024

Changelog

Removed

Remove css modules feature flag from ButtonBase

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@github-actions github-actions bot added the staff Author is a staff member label Nov 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 4, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5222 November 4, 2024 19:18 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.24 KB (-1.52% 🔽)
packages/react/dist/browser.umd.js 102.61 KB (-1.42% 🔽)

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: ca7dd76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-5222 November 4, 2024 23:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5222 December 6, 2024 00:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5222 December 6, 2024 00:40 Inactive
@primer-integration
Copy link

primer-integration bot commented Dec 6, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/353923

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 6, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@jonrohan jonrohan marked this pull request as ready for review December 6, 2024 19:49
@jonrohan jonrohan requested a review from a team as a code owner December 6, 2024 19:49
@jonrohan jonrohan requested a review from langermank December 6, 2024 19:49
@primer-integration
Copy link

primer-integration bot commented Dec 6, 2024

🟢 golden-jobs completed with status success.

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 6, 2024
francinelucca
francinelucca approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a cleanup! 🧹🧹

@jonrohan jonrohan added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit b5ff840 Dec 6, 2024
42 checks passed
@jonrohan jonrohan deleted the remove_css_modules_flag_button branch December 6, 2024 21:45
@primer primer bot mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francinelucca francinelucca francinelucca approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @francinelucca