Catch tooltip v2 errors in older browsers #5171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 39843b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
alondahari
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
broccolinisoup
approved these changes
Oct 31, 2024
Member
broccolinisoup
left a comment
broccolinisoup
left a comment
There was a problem hiding this comment.
Thanks for this PR! It looks good to me. As you mentioned, we can look into it deeper to see why this is happening in the first place despite the polyfill 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add try..catch to the functions to open and close the tooltip v2 to avoid flooding sentry with errors. This is a short term solution until the Primer team can get to the bottom of why this is happening even though we have a polyfill in place.
Rollout strategy
Testing & Reviewing
Try to use a tooltip v2 with an older browser that doesn't support the tooltip api and check for any js errors. We haven't been able to reliably introduce the error, but we're seeing it happen in production.
Merge checklist