Skip to content

Conversation

@keithamus
Copy link
Contributor

@keithamus keithamus commented Oct 18, 2024

As part of https://github.com/github/primer/issues/4028, we wrote out #5037, which provides guidelines for writing React components with CSS modules.

Part of the guidelines were to use PascalCase for naming components. We have a couple of instances where that isn't the case. This fixes that.

Refs https://github.com/github/primer/issues/4248
Closes https://github.com/github/primer/issues/4250

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

This is some simple renames, no release needed.

Testing & Reviewing

Merge checklist

@keithamus keithamus requested a review from a team as a code owner October 18, 2024 14:14
@keithamus keithamus requested a review from TylerJDev October 18, 2024 14:14
@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: cc86e51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 18, 2024
@keithamus keithamus added the skip changeset This change does not need a changelog label Oct 18, 2024
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.1 KB (+0.01% 🔺)
packages/react/dist/browser.umd.js 97.32 KB (-0.17% 🔽)

@keithamus keithamus added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 65f6437 Oct 18, 2024
51 of 52 checks passed
@keithamus keithamus deleted the normalise-classes-to-pascalcase branch October 18, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants