Skip to content

Bug fix: ActionList Group className prop #5132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 16, 2024
Merged

Bug fix: ActionList Group className prop #5132

merged 8 commits into from
Oct 16, 2024

Conversation

@langermank
Copy link
Contributor

@langermank langermank commented Oct 16, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4241

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 37d1326

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 16, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5132 October 16, 2024 15:48 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.62 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js 97.9 KB (-0.04% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5132 October 16, 2024 16:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5132 October 16, 2024 16:25 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/347345

@github-actions github-actions bot temporarily deployed to storybook-preview-5132 October 16, 2024 16:50 Inactive
@primer-integration
Copy link

primer-integration bot commented Oct 16, 2024 •
edited
Loading

🔴 golden-jobs completed with status failure.

@github-actions github-actions bot temporarily deployed to storybook-preview-5132 October 16, 2024 17:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5132 October 16, 2024 17:51 Inactive
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 16, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Oct 16, 2024
@langermank langermank marked this pull request as ready for review October 16, 2024 19:08
@langermank langermank requested review from a team as code owners October 16, 2024 19:08
@langermank langermank requested a review from mperrotti October 16, 2024 19:08
@langermank langermank added this pull request to the merge queue Oct 16, 2024
@joshblack joshblack removed this pull request from the merge queue due to a manual request Oct 16, 2024
@joshblack
Copy link
Member

@broccolinisoup do you think it'd be possible for this to be added to the current release candidate? Or would this be better in the next one?

@broccolinisoup
Copy link
Member

@joshblack yeah go for it 🔥

@joshblack joshblack added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 623a411 Oct 16, 2024
43 checks passed
@joshblack joshblack deleted the action-list-heading-bug branch October 16, 2024 20:48
This was referenced Oct 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@langermank @joshblack @broccolinisoup