Bug fix: ButtonGroup with Tooltips #5123

langermank · 2024-10-14T22:56:59Z

Closes #4129

Made CSS a bit more specific

New

Changed

Removed

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2024-10-14T22:57:02Z

🦋 Changeset detected

Latest commit: d30f6fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-10-14T22:57:30Z

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions · 2024-10-14T22:59:47Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	103.18 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js	103.6 KB (+0.08% 🔺)

iansan5653

I was pointed here from #5452, and just wanted to make a small suggestion: instead of wrapping each item in a container, it might be easier and safer to just switch to using first-of-type and last-of-type selectors - something like &:is(button, a):last-of-type.

jonrohan · 2024-12-17T00:23:43Z

@iansan5653 I attempted to do that here #5343 and that caused these bugs I think cause it's not always all button or all a

github-actions · 2024-12-17T00:23:59Z

Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check #5123 (comment).

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

primer-integration · 2024-12-17T16:16:08Z

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/355518

primer-integration · 2024-12-17T21:17:25Z

🟢 golden-jobs completed with status success.

jonrohan

🥇

jonrohan · 2024-12-17T22:26:52Z

packages/react/src/ButtonGroup/ButtonGroup.tsx

  forwardRef,
 ) {
  const enabled = useFeatureFlag('primer_react_css_modules_ga')
+  const buttons = React.Children.map(children, (child, index) => <div key={index}>{child}</div>)


One alternative idea I had here was to check when the child is the last item, we could add a special classname to re-round the corners, thinking it might be more predictable than relying on direct children selectors. But this also works and I'm fine with it getting out like this.

messy stuff

10c60a6

github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 14, 2024

langermank temporarily deployed to github-pages October 14, 2024 22:58 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5123 October 14, 2024 22:59 Inactive

fix loading button group styles

dc3d231

broccolinisoup temporarily deployed to github-pages October 16, 2024 10:40 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5123 October 16, 2024 10:40 Inactive

broccolinisoup mentioned this pull request Oct 16, 2024

ButtonGroup: Fix button and icon button styling when tooltips are used on them #4723

Closed

13 tasks

langermank added 2 commits October 22, 2024 15:22

lint

62b377f

Merge branch 'main' into button-group-shenanigans

7e45f72

langermank temporarily deployed to github-pages October 22, 2024 22:26 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5123 October 22, 2024 22:27 Inactive

langermank changed the title ~~ButtonGroup WIP~~ Bug fix: ButtonGroup with Tooltips Oct 22, 2024

Create clean-camels-train.md

6db7d64

langermank temporarily deployed to github-pages October 22, 2024 23:00 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5123 October 22, 2024 23:00 Inactive

remove button changes

8ffbf4e

langermank temporarily deployed to github-pages October 23, 2024 14:20 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5123 October 23, 2024 14:21 Inactive

fix(TooltipV2): check for interactive content two levels down

76ea2fa

francinelucca temporarily deployed to github-pages October 23, 2024 18:15 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5123 October 23, 2024 18:15 Inactive

empty case

11f14de

langermank temporarily deployed to github-pages October 23, 2024 23:42 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5123 October 23, 2024 23:42 Inactive

add test

1322e89

langermank temporarily deployed to github-pages November 1, 2024 18:12 — with GitHub Actions Inactive

primer bot temporarily deployed to github-pages December 10, 2024 23:12 Inactive

github-actions bot temporarily deployed to storybook-preview-5123 December 10, 2024 23:12 Inactive

jonrohan removed the do not merge label Dec 11, 2024

jonrohan force-pushed the button-group-shenanigans branch from f08156b to 8621b12 Compare December 11, 2024 02:56

Merge branch 'main' into button-group-shenanigans

4cf2bb5

jonrohan temporarily deployed to github-pages December 11, 2024 03:04 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5123 December 11, 2024 03:04 Inactive

langermank mentioned this pull request Dec 17, 2024

IconButton with tooltip is incompatible with ButtonGroup #5452

Closed

Merge branch 'main' into button-group-shenanigans

0b28db4

langermank temporarily deployed to github-pages December 17, 2024 00:12 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-5123 December 17, 2024 00:12 Inactive

iansan5653 reviewed Dec 17, 2024

View reviewed changes

langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 17, 2024

test(vrt): update snapshots

d30f6fb

github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 17, 2024

primer bot deployed to github-pages December 17, 2024 00:43 View deployment

github-actions bot deployed to storybook-preview-5123 December 17, 2024 00:43 View deployment

github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 17, 2024

jonrohan approved these changes Dec 17, 2024

View reviewed changes

langermank added this pull request to the merge queue Dec 17, 2024

Merged via the queue into main with commit becad7d Dec 17, 2024
42 checks passed

langermank deleted the button-group-shenanigans branch December 17, 2024 22:43

primer bot mentioned this pull request Dec 17, 2024

Release tracking (37.9.0) #5439

Merged

langermank mentioned this pull request Dec 19, 2024

ButtonGroup styling is not compatible with new IconButton tooltips #4790

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bug fix: ButtonGroup with Tooltips #5123

Bug fix: ButtonGroup with Tooltips #5123

Uh oh!

langermank commented Oct 14, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Oct 14, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Oct 14, 2024

Uh oh!

github-actions bot commented Oct 14, 2024 •

edited

Loading

Uh oh!

iansan5653 left a comment

Uh oh!

jonrohan commented Dec 17, 2024

Uh oh!

github-actions bot commented Dec 17, 2024

Uh oh!

primer-integration bot commented Dec 17, 2024

Uh oh!

primer-integration bot commented Dec 17, 2024

Uh oh!

jonrohan left a comment

Uh oh!

jonrohan Dec 17, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Bug fix: ButtonGroup with Tooltips #5123

Bug fix: ButtonGroup with Tooltips #5123

Uh oh!

Conversation

langermank commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-bot bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Oct 14, 2024

Uh oh!

github-actions bot commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

iansan5653 left a comment

Choose a reason for hiding this comment

Uh oh!

jonrohan commented Dec 17, 2024

Uh oh!

github-actions bot commented Dec 17, 2024

Uh oh!

primer-integration bot commented Dec 17, 2024

Uh oh!

primer-integration bot commented Dec 17, 2024

Uh oh!

jonrohan left a comment

Choose a reason for hiding this comment

Uh oh!

jonrohan Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

langermank commented Oct 14, 2024 •

edited

Loading

changeset-bot bot commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading