You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking into the issue it seems that when sx is used with the IconButton, the width defined in the style prop was being ignored. This PR fixes that by ensuring the IconButton respects the width defined in the style prop when the feature flag is enabled.
Changelog
Changed
Bug fix for IconButton to respect the style prop width when the feature flag is on.
Rollout strategy
Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Uh oh! @jonrohan, the image you shared is missing helpful alt text. Check your pull request body.
Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!
integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jonrohan
requested review from
broccolinisoup
and removed request for
siddharthkp
github-actions
bot
added
the
integration-tests: recommended
I saw this weird alignment on https://github.com/github/primer/issues/4028
Looking into the issue it seems that when
sxis used with theIconButton, the width defined in thestyleprop was being ignored. This PR fixes that by ensuring theIconButtonrespects the width defined in thestyleprop when the feature flag is enabled.Changelog
Changed
Bug fix for
IconButtonto respect thestyleprop width when the feature flag is on.Rollout strategy
Merge checklist