Use the IconButton for the close button on Dialog

[jonrohan]

Fixes an issue when the feature flag is enabled for CSS module buttons the close button looses it's hover state. I fixed this issue by removing the styled component DialogCloseButton and used IconButton instead. The only downside is I needed to use unsafeDisableTooltip to remove the Tooltip like the existing functionality. If we want to remove this we should talk to design about allowing a tooltip here.

Changelog

Changed

DialogCloseButton is using IconButton directly

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Visit the storybook story for Dialog and toggle the primer_react_css_modules_staff feature flag on. Then hover over the close x.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: 38d89ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	96.73 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js	97 KB (-0.14% 🔽)