Skip to content

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Sep 26, 2024

Accidentally added bold styles for description on hover and focus, fixed now

Before After
description has bold font weight description has normal font weight

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 107c27f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 26, 2024
@siddharthkp siddharthkp changed the title remove font weight from active styles SelectPanel: remove font weight from active styles Sep 26, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5033 September 26, 2024 13:32 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.12 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 98.45 KB (+0.12% 🔺)

@siddharthkp siddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 27, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5033 September 27, 2024 09:44 Inactive
@siddharthkp siddharthkp changed the title SelectPanel: remove font weight from active styles SelectPanel: Fix font weight from active styles for modern ActionList (behind feature flag) Sep 27, 2024
@github-actions

This comment was marked as resolved.

1 similar comment
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 27, 2024
@siddharthkp siddharthkp marked this pull request as ready for review September 27, 2024 10:00
@siddharthkp siddharthkp requested review from a team as code owners September 27, 2024 10:00
@siddharthkp siddharthkp added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 0b83fe9 Sep 30, 2024
32 checks passed
@siddharthkp siddharthkp deleted the selectpanel-fix-bold-description branch September 30, 2024 11:22
@primer primer bot mentioned this pull request Sep 27, 2024
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: SelectPanel staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants