Skip to content

refactor(BranchName): update BranchName to use CSS Modules #5028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 26, 2024
Merged

refactor(BranchName): update BranchName to use CSS Modules #5028

merged 5 commits into from
Sep 26, 2024

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Sep 25, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4040

Changelog

New

Changed

  • Update BranchName to use CSS Modules behind a feature flag

Removed

Rollout strategy

  • Minor release

@changeset-bot
Copy link

changeset-bot bot commented Sep 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1f46f2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 25, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5028 September 25, 2024 18:16 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.2 KB (+0.26% 🔺)
packages/react/dist/browser.umd.js 98.42 KB (+0.02% 🔺)

@joshblack joshblack marked this pull request as ready for review September 25, 2024 18:46
@joshblack joshblack requested a review from a team as a code owner September 25, 2024 18:46
@github-actions github-actions bot temporarily deployed to storybook-preview-5028 September 25, 2024 18:47 Inactive
@primer-integration
Copy link

primer-integration bot commented Sep 25, 2024

😢 Hi from github/github. The integration workflow has failed: https://github.com/github/github/actions/runs/11039278345

jonrohan
jonrohan reviewed Sep 26, 2024
View reviewed changes
@joshblack joshblack enabled auto-merge September 26, 2024 21:47
@joshblack joshblack added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit c2dd024 Sep 26, 2024
31 checks passed
@joshblack joshblack deleted the refactor/update-branch-name-to-css-modules branch September 26, 2024 22:02
@primer primer bot mentioned this pull request Sep 26, 2024
Merged
siddharthkp added a commit that referenced this pull request Sep 27, 2024
@siddharthkp
Revert "refactor(BranchName): update BranchName to use CSS Modules (#…
ca1642c 
…5028)"

This reverts commit c2dd024.
@siddharthkp siddharthkp mentioned this pull request Sep 27, 2024
Merged
@joshblack joshblack restored the refactor/update-branch-name-to-css-modules branch September 27, 2024 14:11
github-merge-queue bot pushed a commit that referenced this pull request Sep 27, 2024
@siddharthkp
Revert "refactor(BranchName): update BranchName to use CSS Modules (#…
c5696b3 
…5028)" (#5039)

This reverts commit c2dd024.
@github-actions github-actions bot temporarily deployed to storybook-preview-5040 September 27, 2024 14:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank Awaiting requested review from langermank

Assignees

No one assigned

Labels

staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack @jonrohan