Skip to content

Move Button component feature flag from primer_react_css_modules_team to primer_react_css_modules_staff #5023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Move Button component feature flag from primer_react_css_modules_team to primer_react_css_modules_staff #5023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4887ce
Move Button to staff feature flag
jonrohan Sep 24, 2024
d38fef2
Create little-bats-approve.md
jonrohan Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-bats-approve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Move Button component feature flag from primer_react_css_modules_team to primer_react_css_modules_staff
74 changes: 37 additions & 37 deletions e2e/components/Button.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -29,7 +29,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -54,7 +54,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -69,7 +69,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -94,7 +94,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -109,7 +109,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -134,7 +134,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -149,7 +149,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -174,7 +174,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -189,7 +189,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -211,7 +211,7 @@ test.describe('Button', () => {
id: 'components-button-features--large',
globals: {
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -230,7 +230,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -245,7 +245,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -267,7 +267,7 @@ test.describe('Button', () => {
id: 'components-button-features--medium',
globals: {
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -286,7 +286,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -301,7 +301,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -323,7 +323,7 @@ test.describe('Button', () => {
id: 'components-button-features--small',
globals: {
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -342,7 +342,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -357,7 +357,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -382,7 +382,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -397,7 +397,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -422,7 +422,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -437,7 +437,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -462,7 +462,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -477,7 +477,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -502,7 +502,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -517,7 +517,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -542,7 +542,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -559,7 +559,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -584,7 +584,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -601,7 +601,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -626,7 +626,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -643,7 +643,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -668,7 +668,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -689,7 +689,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -710,7 +710,7 @@ test.describe('Button', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: featureFlagOn,
primer_react_css_modules_staff: featureFlagOn,
},
},
})
Expand All @@ -730,7 +730,7 @@ test.describe('Button', () => {
// globals: {
// colorScheme: theme,
// featureFlags: {
// primer_react_css_modules_team: featureFlagOn,
// primer_react_css_modules_staff: featureFlagOn,
// },
// },
// })
Expand Down
Loading
Loading