Skip to content

chore(deps): update @playwright/test to 1.47.2 #5016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2024
Merged

chore(deps): update @playwright/test to 1.47.2 #5016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2207c37
chore(deps): update @playwright/test to 1.47.2
joshblack Sep 24, 2024
5fc84b2
test(vrt): update snapshots
joshblack Sep 24, 2024
df7ffa4
Merge branch 'main' of github.com:primer/react into chore/update-play…
joshblack Oct 7, 2024
fc23aa5
test(vrt): update snapshots
joshblack Oct 7, 2024
cef9624
Merge branch 'main' into chore/update-playwright-to-1.47.2
joshblack Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
echo "pid=$pid" >> $GITHUB_OUTPUT
sleep 5
- name: Run VRT
uses: docker://mcr.microsoft.com/playwright:v1.43.0-jammy
uses: docker://mcr.microsoft.com/playwright:v1.47.2-jammy
env:
STORYBOOK_URL: 'http://172.17.0.1:6006'
with:
Expand Down Expand Up @@ -285,7 +285,7 @@ jobs:
echo "pid=$pid" >> $GITHUB_OUTPUT
sleep 5
- name: Run AAT
uses: docker://mcr.microsoft.com/playwright:v1.43.0-jammy
uses: docker://mcr.microsoft.com/playwright:v1.47.2-jammy
env:
STORYBOOK_URL: 'http://172.17.0.1:6006'
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vrt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
echo "pid=$pid" >> $GITHUB_OUTPUT
sleep 5
- name: Run VRT
uses: docker://mcr.microsoft.com/playwright:v1.43.0-jammy
uses: docker://mcr.microsoft.com/playwright:v1.47.2-jammy
env:
STORYBOOK_URL: 'http://172.17.0.1:6006'
with:
Expand Down
Binary file modified ...shots/SelectPanel-Default-forced-colors-dark-modern-action-list--true-linux.png
View file
Open in desktop
Copy link
Member

@broccolinisoup broccolinisoup Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the marked checkboxes in the before screenshot were empty 🤔 And I think the before one uses modern action list (the ff flag is on?). I think the added screenshot is the expected one though. I don't know, I am confused 😅

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 15 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@github/markdownlint-github": "^0.6.0",
"@github/prettier-config": "0.0.6",
"@mdx-js/react": "1.6.22",
"@playwright/test": "1.43.0",
"@playwright/test": "^1.47.2",
"@prettier/sync": "0.5.1",
"@primer/stylelint-config": "^13.0.1-rc.5358628",
"@size-limit/preset-big-lib": "11.0.2",
Expand Down
16 changes: 15 additions & 1 deletion script/test-e2e
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,26 @@
#!/bin/bash

set -e
set -x

PLAYWRIGHT_VERSION=$(npm --json list @playwright/test | jq --raw-output '.dependencies["@playwright/test"].version')

if [ -z "$PLAYWRIGHT_VERSION" ]; then
echo "Unable to find Playwright version. Make sure @playwright/test is installed."
exit 1
fi

echo "Using Playwright version $PLAYWRIGHT_VERSION"

if [ -z "$STORYBOOK_URL" ]; then
STORYBOOK_URL="http://host.docker.internal:6006"
fi

echo "Using Storybook at: $STORYBOOK_URL"

docker run --rm \
--network host \
-v $(pwd):/workspace \
-w /workspace \
-it "mcr.microsoft.com/playwright:v$PLAYWRIGHT_VERSION-jammy" \
/bin/bash -c "npm install && STORYBOOK_URL=http://host.docker.internal:6006 npx playwright test $@"
/bin/bash -c "npm install && STORYBOOK_URL=$STORYBOOK_URL npx playwright test $@"
Loading