Skip to content

chore(AvatarPair): Convert AvatarPair to CSS modules #5002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2024
Merged

chore(AvatarPair): Convert AvatarPair to CSS modules #5002

merged 4 commits into from
Sep 23, 2024

Conversation

@jonrohan
Copy link
Member

Closes https://github.com/github/primer/issues/4023

I opted in this case to go directly to CSS modules as this component will be removed in the next major release.

Changelog

Changed

Converts AvatarPair to CSS modules

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan jonrohan requested a review from a team as a code owner September 20, 2024 21:06
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: abc9f25

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 20, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5002 September 20, 2024 21:09 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.96 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js 98.23 KB (-0.05% 🔽)

@jonrohan jonrohan enabled auto-merge September 20, 2024 21:10
@jonrohan jonrohan added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 20, 2024
@primer primer bot requested a review from a team as a code owner September 20, 2024 21:34
@primer primer bot requested a review from langermank September 20, 2024 21:34
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 20, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5002 September 20, 2024 21:36 Inactive
@jonrohan jonrohan added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 23, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 23, 2024
@jonrohan jonrohan added this pull request to the merge queue Sep 23, 2024
Merged via the queue into main with commit 9bd5c89 Sep 23, 2024
32 checks passed
@jonrohan jonrohan deleted the css_modules_avatarpair branch September 23, 2024 17:05
@primer primer bot mentioned this pull request Sep 23, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp siddharthkp is a code owner automatically assigned from primer/engineer-reviewers

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @joshblack