Skip to content

Conversation

@TylerJDev
Copy link
Member

Part of https://github.com/github/primer/issues/3441

Adds a visual title to textarea example in storybook. This addresses a potential accessibility issue where the current example would fail 3.3.2 Labels or Instructions.

Changelog

Changed

  • Adds "title" (heading) to textarea story

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: ce2fcbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Sep 17, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4983 September 17, 2024 18:57 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.5 KB (0%)
packages/react/dist/browser.umd.js 97.67 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4983 September 18, 2024 01:20 Inactive
@TylerJDev TylerJDev marked this pull request as ready for review September 18, 2024 01:21
@TylerJDev TylerJDev requested a review from a team as a code owner September 18, 2024 01:21
@TylerJDev TylerJDev requested a review from joshblack September 18, 2024 01:21
@TylerJDev TylerJDev changed the title Textarea: Add "title" to form example Textarea: Add "title" to story example Sep 18, 2024
@TylerJDev TylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 18, 2024
@primer primer bot requested a review from a team as a code owner September 18, 2024 01:58
@primer primer bot requested a review from emilybrick September 18, 2024 01:58
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 18, 2024
@TylerJDev TylerJDev added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit d1b48bc Sep 19, 2024
@TylerJDev TylerJDev deleted the tylerjdev/quick-storybook-a11y-fix-textarea branch September 19, 2024 00:11
TylerJDev added a commit that referenced this pull request Sep 23, 2024
* Add "title" to form example

* Add caption to explain purpose

* test(vrt): update snapshots

---------

Co-authored-by: TylerJDev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants