Skip to content

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Sep 16, 2024

We've identified usage of wildcard imports downstream 👀 As a result, this PR adds these imports to named entry points that we have (and also creates a new one).

With these wildcard exports now coming from a named entry point, we can update dotcom to use these new exports before officially removing them ☠️

The full list of wildcard imports identified is at: https://github.com/primer/eslint-plugin-primer-react/blob/main/src/rules/no-wildcard-imports.js#L5

Changelog

New

  • Add a test-helpers entrypoint for @primer/react/test-helpers
  • Add VisuallyHidden, VisuallyHiddenProps to @primer/react
  • Add BetterCssProperties to @primer/react
  • Add BetterSystemStyleObject to @primer/react
  • Add IssueLabelTokenProps to @primer/react
  • Add LabelColorOptions to @primer/react
  • Add useIsomorphicLayoutEffect to @primer/react
  • Add useProvidedRefOrCreate to @primer/react
  • Add ActionListGroupedListProps, ActionListGroupProps, ActionListItemProps to @primer/react/deprecated
  • Add DefaultFeatureFlags to @primer/react/experimental

Changed

Removed

Rollout strategy

  • Minor release

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2024

🦋 Changeset detected

Latest commit: 97c8b54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 16, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4976 September 16, 2024 20:59 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.92 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js 98.29 KB (+0.05% 🔺)

@joshblack joshblack marked this pull request as ready for review September 18, 2024 20:46
@joshblack joshblack requested a review from a team as a code owner September 18, 2024 20:46
@github-actions github-actions bot temporarily deployed to storybook-preview-4976 September 18, 2024 20:49 Inactive
@joshblack
Copy link
Member Author

joshblack commented Sep 23, 2024

bump @siddharthkp when you have a second!

@joshblack joshblack added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit f448b1b Sep 24, 2024
32 checks passed
@joshblack joshblack deleted the feat/add-wildcard-re-exports branch September 24, 2024 19:37
@primer primer bot mentioned this pull request Sep 24, 2024
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/343590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants