Skip to content

refactor(CounterLabel): update to use CSS Modules behind flag #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 25, 2024
Merged

refactor(CounterLabel): update to use CSS Modules behind flag #4965

merged 18 commits into from
Sep 25, 2024

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Sep 13, 2024 •
edited by jonrohan
Loading

Closes https://github.com/github/primer/issues/3918

Changelog

New

Changed

  • Update CounterLabel to use a styled version under the hood instead of box to make it easier to migrate
  • Update CounterLabel to use CSS Modules
  • Refactor e2e tests for CounterLabel
  • Add additional story for CounterLabel

Removed

Rollout strategy

  • Minor release

@joshblack joshblack requested a review from a team as a code owner September 13, 2024 20:46
@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d4119d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 13, 2024 20:48 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.31 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js 98.56 KB (-0.02% 🔽)

@primer primer deleted a comment from primer-integration bot Sep 17, 2024
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/342701

@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 20, 2024 20:59 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 20, 2024 21:02 Inactive
langermank
langermank reviewed Sep 20, 2024
View reviewed changes
@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 20, 2024 23:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 24, 2024 16:50 Inactive
@joshblack joshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Sep 24, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 24, 2024 18:30 Inactive
@joshblack joshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Sep 24, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 24, 2024 19:21 Inactive
@primer primer bot requested a review from a team as a code owner September 24, 2024 19:29
@primer primer bot requested a review from maximedegreve September 24, 2024 19:29
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 24, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4965 September 24, 2024 19:31 Inactive
@joshblack joshblack added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024
@joshblack joshblack enabled auto-merge September 25, 2024 15:20
@joshblack joshblack added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 5426a9a Sep 25, 2024
32 checks passed
@joshblack joshblack deleted the 3918-update-counter-label branch September 25, 2024 15:43
@primer primer bot mentioned this pull request Sep 25, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank langermank approved these changes

@maximedegreve maximedegreve Awaiting requested review from maximedegreve maximedegreve is a code owner automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshblack @jonrohan @langermank