Skip to content

refactor(Checkbox): update Checkbox to use CSS Modules behind flag #4962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 24, 2024
Merged

refactor(Checkbox): update Checkbox to use CSS Modules behind flag #4962

merged 15 commits into from
Sep 24, 2024

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Sep 13, 2024 •
edited by jonrohan
Loading

Closes https://github.com/github/primer/issues/3919

Changelog

New

Changed

  • Update Checkbox to use CSS Modules behind flag

Removed

Rollout strategy

  • Minor release

@joshblack joshblack requested a review from a team as a code owner September 13, 2024 19:38
@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2247fce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4962 September 13, 2024 19:40 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.98 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js 98.3 KB (+0.05% 🔺)

@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4962 September 13, 2024 20:01 Inactive
@primer primer bot requested a review from a team as a code owner September 13, 2024 20:08
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 13, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4962 September 13, 2024 20:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4962 September 17, 2024 16:35 Inactive
langermank
langermank approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the focus color changes are just catching up with a previous primitives version bump

@github-actions github-actions bot temporarily deployed to storybook-preview-4962 September 20, 2024 21:10 Inactive
@joshblack joshblack added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 1977a68 Sep 24, 2024
32 checks passed
@joshblack joshblack deleted the 3919-update-checkbox-css-modules-2 branch September 24, 2024 19:28
@primer primer bot mentioned this pull request Sep 24, 2024
Merged
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344079

@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

@langermank langermank langermank approved these changes

Assignees

No one assigned

Labels

staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshblack @jonrohan @langermank