Skip to content

Conversation

@langermank
Copy link
Contributor

Part of https://github.com/github/primer/issues/3815

Changelog

Changed

  • The ButtonBase component uses CSS modules behind the flag

Rollout strategy

  • Minor release

Testing & Reviewing

Snapshots should match with flag on/off

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 923daae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 9, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 97.47 KB (+0.39% 🔺)
packages/react/dist/browser.umd.js 97.71 KB (+0.21% 🔺)

@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 9, 2024
@primer primer bot temporarily deployed to github-pages September 9, 2024 20:23 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4940 September 9, 2024 20:23 Inactive
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 9, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4940 September 9, 2024 22:09 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 9, 2024
@primer primer bot temporarily deployed to github-pages September 9, 2024 22:19 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4940 September 9, 2024 22:20 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4940 September 13, 2024 18:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4940 September 13, 2024 18:18 Inactive
@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 13, 2024
@langermank langermank added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Sep 13, 2024
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/342146

@langermank langermank added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 4d3b504 Sep 13, 2024
32 checks passed
@langermank langermank deleted the button-branch-was-cursed branch September 13, 2024 21:10
@primer primer bot mentioned this pull request Sep 13, 2024
TylerJDev pushed a commit that referenced this pull request Sep 23, 2024
* copy

* setting

* Create olive-donkeys-exercise.md

* test(vrt): update snapshots

* update tests

* we got this

* vrt dont lie

* test(vrt): update snapshots

* more fixes

* fix focus outline

* where where where

* fix nesting

* fix nesting i think

* test vrt

* cleanup

* important...

* try reverting this change?

* try resetting stories

* reset from main

* fix classname on iconbutton

* try no calc

* more digits??

* test(vrt): update snapshots

* lets goooooo

* oops

* reset

* Revert "reset"

This reverts commit b82f00c.

* reset

* test(vrt): update snapshots

---------

Co-authored-by: langermank <[email protected]>
@primer primer bot mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants