Skip to content

Bug fix: invisible Button variant missing background color when disabled #4928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Bug fix: invisible Button variant missing background color when disabled #4928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
62fc5d7
fix
langermank Sep 6, 2024
ffcde80
Create serious-terms-sniff.md
langermank Sep 6, 2024
d80464a
snaps
langermank Sep 6, 2024
303af71
delete snaps to regen
langermank Sep 6, 2024
d96d148
use transparent as fallback its fine
langermank Sep 6, 2024
8098e33
snaps
langermank Sep 6, 2024
105426a
test(vrt): update snapshots
langermank Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/serious-terms-sniff.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Bug fix: `invisible` Button variant missing background color when disabled
Binary file modified ...s/components/Button.test.ts-snapshots/Button-Disabled-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...shots/components/Button.test.ts-snapshots/Button-Disabled-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...omponents/Button.test.ts-snapshots/Button-Disabled-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ht/snapshots/components/Button.test.ts-snapshots/Button-Disabled-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...s/components/Button.test.ts-snapshots/Button-Disabled-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../components/Button.test.ts-snapshots/Button-Disabled-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...mponents/Button.test.ts-snapshots/Button-Disabled-light-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...t/snapshots/components/Button.test.ts-snapshots/Button-Disabled-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .../components/Button.test.ts-snapshots/Button-Disabled-light-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions packages/react/src/Button/__tests__/__snapshots__/Button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1680,6 +1680,7 @@ exports[`Button styles invisible button appropriately 1`] = `
cursor: not-allowed;
box-shadow: none;
color: primer.fg.disabled;
background-color: var(--button-invisible-bgColor-disabled,transparent);
}

.c0:disabled [data-component=ButtonCounter],
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/Button/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export const getVariantStyles = (variant: VariantType = 'default', theme?: Theme
},
'&:disabled': {
color: 'primer.fg.disabled',
backgroundColor: `var(--button-invisible-bgColor-disabled, transparent)`,
'[data-component=ButtonCounter], [data-component="leadingVisual"], [data-component="trailingAction"]': {
color: 'inherit',
},
Expand Down
3 changes: 3 additions & 0 deletions packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,6 +1761,7 @@ exports[`TextInput renders trailingAction icon button 1`] = `
cursor: not-allowed;
box-shadow: none;
color: var(--fgColor-disabled,var(--color-primer-fg-disabled,#8c959f));
background-color: var(--button-invisible-bgColor-disabled,transparent);
}

.c4:disabled [data-component=ButtonCounter],
Expand Down Expand Up @@ -2391,6 +2392,7 @@ exports[`TextInput renders trailingAction text button 1`] = `
cursor: not-allowed;
box-shadow: none;
color: var(--fgColor-disabled,var(--color-primer-fg-disabled,#8c959f));
background-color: var(--button-invisible-bgColor-disabled,transparent);
}

.c4:disabled [data-component=ButtonCounter],
Expand Down Expand Up @@ -2882,6 +2884,7 @@ exports[`TextInput renders trailingAction text button with a tooltip 1`] = `
cursor: not-allowed;
box-shadow: none;
color: var(--fgColor-disabled,var(--color-primer-fg-disabled,#8c959f));
background-color: var(--button-invisible-bgColor-disabled,transparent);
}

.c4:disabled [data-component=ButtonCounter],
Expand Down