Skip to content

Moving Link CSS modules to staff feature flag #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Moving Link CSS modules to staff feature flag #4916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e092f2d
Moving Link CSS modules to staff feature flag
jonrohan Sep 3, 2024
a9db5d3
Create cool-llamas-live.md
jonrohan Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cool-llamas-live.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Moving Link CSS modules to staff feature flag
4 changes: 2 additions & 2 deletions e2e/components/Link.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ test.describe('Link', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: true,
primer_react_css_modules_staff: true,
},
},
})
Expand All @@ -55,7 +55,7 @@ test.describe('Link', () => {
globals: {
colorScheme: theme,
featureFlags: {
primer_react_css_modules_team: true,
primer_react_css_modules_staff: true,
},
},
})
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Link/Link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const StyledLink = styled.a<StyledLinkProps>`
`

const Link = forwardRef(({as: Component = 'a', className, ...props}, forwardedRef) => {
const enabled = useFeatureFlag('primer_react_css_modules_team')
const enabled = useFeatureFlag('primer_react_css_modules_staff')

const innerRef = React.useRef<HTMLAnchorElement>(null)
useRefObjectAsForwardedRef(forwardedRef, innerRef)
Expand Down