Skip to content

(waiting) Select Panel: Add home and end keys for keyboard navigation #4903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 68 commits into from
Closed

(waiting) Select Panel: Add home and end keys for keyboard navigation #4903

wants to merge 68 commits into from

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Sep 3, 2024

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

broccolinisoup and others added 30 commits July 30, 2024 14:51
@broccolinisoup
super wip
9cee0a4
@broccolinisoup
just use the actionlist component and revert the type updates
c7aa5de
@broccolinisoup
Update packages/react/src/FilteredActionList/FilteredActionList.tsx
40a0c45
@broccolinisoup
Some more progress
344f6ce
@broccolinisoup
revert the type changes and cast it :/
fa5f5a6
@broccolinisoup
clean
3cd9ecc
@broccolinisoup
wip
0003e59
@broccolinisoup
wip wip
713b5ad
@broccolinisoup
add stories
6fc7f2b
@broccolinisoup
fix linting
a246981
@broccolinisoup
add tests for groups
e209f47
@broccolinisoup
Merge branch 'main' into select-panel-action-list
26cddc1
@broccolinisoup
Merge branch 'select-panel-story-and-tests' into select-panel-action-…
b1199fb 
…list
@broccolinisoup
Map groups
b669cff
@broccolinisoup
Merge branch 'main' into select-panel-story-and-tests
1012662
@broccolinisoup
Update story names for e2e tests
67dc5c9
@broccolinisoup
oops remove unintended file
c66feb5
@broccolinisoup
update story name
4fbb3c5
@broccolinisoup
same - update story name
2d5e2b2
@broccolinisoup
disable animations
cee7737
@broccolinisoup @github-actions
test(vrt): update snapshots
9c972c3
@broccolinisoup
Merge branch 'select-panel-story-and-tests' into select-panel-action-…
17e4ca8 
…list
@broccolinisoup
Update tests since new action list has different semantics for group …
26b6fe6 
…headings
@broccolinisoup
Merge branch 'main' into select-panel-action-list
42c50c0
@broccolinisoup
logging
0d0004f
@broccolinisoup
pass the rest
3ba9bc7
@broccolinisoup
extract children and use before text
92ab9c2
@broccolinisoup
remove logging
7b3d5e6
@siddharthkp
Merge branch 'main' into select-panel-action-list
1cf1e09
@siddharthkp @github-actions
test(vrt): update snapshots
92303d0
siddharthkp and others added 20 commits August 27, 2024 15:47
@siddharthkp
clean up dual filter list setup
5dc6adb
@siddharthkp
run jests test with both states of feature flags
85e0bb4
@siddharthkp
refactor snapshot tests with scenarios
0ee74e1
@siddharthkp
remove feature flag for main
798008e
@siddharthkp
Merge branch 'main' into select-panel-action-list
beca8db
@siddharthkp
Merge branch 'selectpanel-prepare-scenarios' into select-panel-action…
14fd206 
…-list
@siddharthkp @github-actions
test(vrt): update snapshots
185eb17
@siddharthkp
add feature flag to e2e matrix
318aa99
@siddharthkp @github-actions
test(vrt): update snapshots
e9c523c
@siddharthkp
backward compat: allow groupMetadata to be empty array
efd1216
@siddharthkp
Merge branch 'select-panel-action-list' of github.com:primer/react in…
cd9a931 
…to select-panel-action-list
@siddharthkp
Merge branch 'main' into select-panel-action-list
619ff96
@siddharthkp
sigh newline
e3fe7b8
@siddharthkp
Create sour-cooks-dress.md
ebac341
@siddharthkp
Merge branch 'main' into select-panel-action-list
0513474
@siddharthkp
copy SelectPanel snapshots from main
2afa236
@siddharthkp
remove unrelated changes in this PR
0f38bf4
@siddharthkp @github-actions
test(vrt): update snapshots
f72aa55
@siddharthkp
add more bindkeys
9d6ecdc
@siddharthkp
add for deprecated version as well
e33bc33
@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2024

🦋 Changeset detected

Latest commit: e33bc33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.93 KB (+0.58% 🔺)
packages/react/dist/browser.umd.js 97.12 KB (+0.42% 🔺)

@primer-integration
Copy link

primer-integration bot commented Sep 3, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/340195

@siddharthkp siddharthkp changed the title Select Panel: Add home and end keys for keyboard navigation (waiting) Select Panel: Add home and end keys for keyboard navigation Sep 3, 2024
@siddharthkp
Copy link
Member Author

siddharthkp commented Sep 3, 2024

Copied over to #4906

@siddharthkp siddharthkp closed this Sep 3, 2024
@siddharthkp siddharthkp deleted the select-panel--keyboard-add-home-and-end branch October 4, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddharthkp @broccolinisoup