Skip to content

Refactor Link, Blankslate, Heading to use :where css #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Refactor Link, Blankslate, Heading to use :where css #4858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c0a264
Refactor Link, Blankslate, Heading to use :where css
jonrohan Aug 16, 2024
c091099
Create early-lions-vanish.md
jonrohan Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-lions-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Refactor Link, Blankslate, Heading to use :where css
8 changes: 4 additions & 4 deletions packages/react/src/Blankslate/Blankslate.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@
/* stylelint-disable-next-line primer/spacing */
padding: var(--blankslate-outer-padding-block) var(--blankslate-outer-padding-inline);

&[data-spacious='true'] {
&:where([data-spacious='true']) {
--blankslate-outer-padding-block: var(--base-size-80);
--blankslate-outer-padding-inline: var(--base-size-40);
}

&[data-border='true'] {
&:where([data-border='true']) {
border: var(--borderWidth-thin) solid var(--borderColor-default);
border-radius: var(--borderRadius-medium);
}

&[data-narrow='true'] {
&:where([data-narrow='true']) {
max-width: 485px;
margin: 0 auto;
}
Expand Down Expand Up @@ -63,7 +63,7 @@
--blankslate-outer-padding-block: var(--base-size-20);
--blankslate-outer-padding-inline: var(--base-size-20);

&[data-spacious='true'] {
&:where([data-spacious='true']) {
--blankslate-outer-padding-block: var(--base-size-44);
--blankslate-outer-padding-inline: var(--base-size-28);
}
Expand Down
6 changes: 3 additions & 3 deletions packages/react/src/Heading/Heading.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
font-size: var(--text-title-size-large);
font-weight: var(--base-text-weight-semibold);

&[data-variant='large'] {
&:where([data-variant='large']) {
font: var(--text-title-shorthand-large);
}

&[data-variant='medium'] {
&:where([data-variant='medium']) {
font: var(--text-title-shorthand-medium);
}

&[data-variant='small'] {
&:where([data-variant='small']) {
font: var(--text-title-shorthand-small);
}
}
6 changes: 3 additions & 3 deletions packages/react/src/Link/Link.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,16 @@
}

/* Deprecated: but need to support backwards compatibility */
&[data-underline='true'],
&:where([data-underline='true']),
/*
Inline links (inside a text block), however, should have underline based on accessibility setting set in data-attribute
Note: setting underline={false} does not override this
*/
[data-a11y-link-underlines='true'] &[data-inline='true'] {
[data-a11y-link-underlines='true'] &:where([data-inline='true']) {
text-decoration: underline;
}

&[data-muted='true'] {
&:where([data-muted='true']) {
color: var(--fgColor-muted);

&:hover {
Expand Down