Skip to content

feat(Banner): add support for custom icons when variant="upsell" #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 13, 2024
Merged

feat(Banner): add support for custom icons when variant="upsell" #4838

merged 4 commits into from
Aug 13, 2024

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Aug 12, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/3784

Update Banner to support customizing icons with both info and upsell

Changelog

New

  • Add support for custom icons when Banner variant="upsell"

Changed

Removed

Rollout strategy

  • Minor release

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: ede98f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 12, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.2 KB (0%)
packages/react/dist/browser.umd.js 96.46 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4838 August 12, 2024 15:15 Inactive
@joshblack joshblack changed the title Update Banner.tsx feat(Banner): add support for custom icons when variant="upsell" Aug 12, 2024
@joshblack joshblack marked this pull request as ready for review August 12, 2024 16:48
@joshblack joshblack requested a review from a team as a code owner August 12, 2024 16:48
@github-actions github-actions bot temporarily deployed to storybook-preview-4838 August 12, 2024 16:50 Inactive
siddharthkp
siddharthkp approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joshblack joshblack added this pull request to the merge queue Aug 13, 2024
Merged via the queue into main with commit 7a3b55d Aug 13, 2024
@joshblack joshblack deleted the joshblack-patch-1 branch August 13, 2024 15:19
@primer primer bot mentioned this pull request Aug 12, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/engineer-reviewers

Assignees

No one assigned

Labels

staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack @siddharthkp