Skip to content

SelectPanel: Add stories and tests for documentation purposes #4829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 12, 2024
Merged

SelectPanel: Add stories and tests for documentation purposes #4829

merged 13 commits into from
Aug 12, 2024

Conversation

@broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Aug 8, 2024 •
edited
Loading

Changelog

New

  • Added stories for undocumented features such as groups etc

Changed

  • Reorganised the stories based on our recent conventions
  • Re-exported the deprecated ActionList types from SelectPanel

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6170f77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.2 KB (0%)
packages/react/dist/browser.umd.js 96.46 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4829 August 8, 2024 02:46 Inactive
@broccolinisoup broccolinisoup added the skip changeset This change does not need a changelog label Aug 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4829 August 8, 2024 03:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4829 August 8, 2024 06:45 Inactive
@broccolinisoup broccolinisoup marked this pull request as ready for review August 8, 2024 06:51
@broccolinisoup broccolinisoup requested a review from a team as a code owner August 8, 2024 06:51
siddharthkp
siddharthkp reviewed Aug 9, 2024
View reviewed changes
siddharthkp
siddharthkp reviewed Aug 9, 2024
View reviewed changes
packages/react/src/FilteredActionList/FilteredActionList.tsx
import {get} from '../constants'
import {ActionList} from '../deprecated/ActionList'
import type {GroupedListProps, ListPropsBase} from '../deprecated/ActionList/List'
import type {GroupedListProps, ListPropsBase} from '../SelectPanel/types'
Copy link
Member

@siddharthkp siddharthkp Aug 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non blocker) Should we bring FilteredActionList into src/SelectPanel, it's not used anywhere else. (And we probably don't want it to be used anywhere else?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me! Perhaps in a follow-up PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think we exported it recently? #4816

This comment was marked as outdated.

Sign in to view

siddharthkp
siddharthkp approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you adding more stories!

camertron
camertron approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you! 🎉

@github-actions github-actions bot temporarily deployed to storybook-preview-4829 August 12, 2024 01:30 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4829 August 12, 2024 02:49 Inactive
@broccolinisoup broccolinisoup added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Aug 12, 2024
@primer primer bot requested a review from a team as a code owner August 12, 2024 03:04
@primer primer bot requested a review from howdyray August 12, 2024 03:04
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 12, 2024
@primer primer bot temporarily deployed to github-pages August 12, 2024 03:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4829 August 12, 2024 03:09 Inactive
@broccolinisoup broccolinisoup force-pushed the select-panel-story-and-tests branch from 80174ab to cee7737 Compare August 12, 2024 03:24
@github-actions github-actions bot temporarily deployed to storybook-preview-4829 August 12, 2024 03:28 Inactive
@broccolinisoup broccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 12, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 12, 2024
@primer primer bot temporarily deployed to github-pages August 12, 2024 03:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4829 August 12, 2024 03:56 Inactive
@broccolinisoup broccolinisoup added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@broccolinisoup broccolinisoup added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 529e1a3 Aug 12, 2024
@broccolinisoup broccolinisoup deleted the select-panel-story-and-tests branch August 12, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@langermank langermank langermank approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/engineer-reviewers

@howdyray howdyray Awaiting requested review from howdyray howdyray is a code owner automatically assigned from primer/design-reviewers

+1 more reviewer

@camertron camertron camertron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@broccolinisoup @camertron @siddharthkp @langermank