Skip to content

Refactor Link component to use CSS modules #4828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 14, 2024
Merged

Refactor Link component to use CSS modules #4828

merged 12 commits into from
Aug 14, 2024

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Aug 8, 2024 •
edited
Loading

Part of https://github.com/github/primer/issues/3719

Changed

  • Update Link component to use CSS Modules
  • Add feature flag to Link component to toggle between styled-components and CSS Modules
  • Use feature flag for VRT in Link

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 6f10e4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.13 KB (-0.08% 🔽)
packages/react/dist/browser.umd.js 96.48 KB (+0.03% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4828 August 8, 2024 00:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4828 August 12, 2024 18:09 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4828 August 12, 2024 18:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4828 August 12, 2024 18:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4828 August 12, 2024 18:57 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4828 August 12, 2024 19:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4828 August 12, 2024 20:18 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4828 August 13, 2024 23:19 Inactive
@jonrohan jonrohan requested a review from joshblack August 13, 2024 23:31
@jonrohan jonrohan marked this pull request as ready for review August 13, 2024 23:35
@jonrohan jonrohan requested a review from a team as a code owner August 13, 2024 23:35
langermank
langermank approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@joshblack joshblack mentioned this pull request Aug 14, 2024
Merged
1 task
@jonrohan jonrohan added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 1a674f7 Aug 14, 2024
@jonrohan jonrohan deleted the css_modules_convert_link branch August 14, 2024 22:18
@primer primer bot mentioned this pull request Aug 14, 2024
Merged
jonrohan added a commit that referenced this pull request Aug 15, 2024
@jonrohan @joshblack
Refactor Link component to use CSS modules (#4828)
1e249d5 
* Refactor Link to use CSS modules

* Remove needless disable

* Add newline

* Create quick-adults-buy.md

* Run tests inside fhte feature flag also

* Fix naming

* Rails interpolation got me

* test(e2e): update e2e tests for link (#4825)

Co-authored-by: Josh Black <[email protected]>

* Remove example-nextjs

---------

Co-authored-by: Josh Black <[email protected]>
Co-authored-by: Josh Black <[email protected]>
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@langermank langermank langermank approved these changes

Assignees

No one assigned

Labels

staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jonrohan @joshblack @langermank