feat(FeatureFlags): broaden feature flag type to accept undefined #4554

joshblack · 2024-05-02T21:55:16Z

This change makes it easier to integrate our FeatureFlags component in scenarios where a feature flag value may be boolean | undefined.

Changelog

New

Changed

The type of a flag has been loosened to boolean | undefined

Removed

Rollout strategy

Minor release

Testing & Reviewing

Verify that FeatureFlags now accepts a flags prop where the values can be undefined and they are correctly initialized in FeatureFlagScope

changeset-bot · 2024-05-02T21:55:19Z

🦋 Changeset detected

Latest commit: 1bfb3ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-05-02T21:58:48Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	87.98 KB (0%)
packages/react/dist/browser.umd.js	88.28 KB (0%)

siddharthkp · 2024-05-03T12:10:29Z

.changeset/grumpy-coats-worry.md

@@ -0,0 +1,5 @@
+---
+'@primer/react': minor


patch?

Suggested change

'@primer/react': minor

'@primer/react': patch

@siddharthkp my thinking for picking minor was that this change seemed like it was adding functionality where a type was broadended to accept more values. Right now in our versioning doc we have that as a minor over at: https://github.com/primer/react/blob/main/contributor-docs/versioning.md#the-type-of-a-prop-is-broadened

Let me know if this seems more like a bug fix though or if it'd be worth talking about updating the version doc 👍

siddharthkp

LGTM!

.changeset/grumpy-coats-worry.md

) * feat(FeatureFlags): loosen feature flag type to accept undefined * chore: add changeset * Update .changeset/grumpy-coats-worry.md --------- Co-authored-by: Josh Black <[email protected]>

* Add new props to `FormControl.Label` * Add conditional * Add changeset * Update docs json * Add more examples * chore(deps-dev): bump ejs from 3.1.9 to 3.1.10 (#4549) Bumps [ejs](https://github.com/mde/ejs) from 3.1.9 to 3.1.10. - [Release notes](https://github.com/mde/ejs/releases) - [Commits](mde/ejs@v3.1.9...v3.1.10) --- updated-dependencies: - dependency-name: ejs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * BranchName: Add style for span and add v8 tokens (#4556) * add style for branchName as span adn add v8 tokens * added changeset * Update thin-ligers-turn.md * test(vrt): update snapshots * use not a instead of matching for span --------- Co-authored-by: Siddharth Kshetrapal <[email protected]> Co-authored-by: lukasoppermann <[email protected]> * refactor(Banner): update region to use a dedicated aria-label (#4539) * refactor(Banner): update region to use a dedicated aria-label * chore: add changeset, update config to exclude codesandbox * feat: add aria-label to Banner * Update packages/react/src/Banner/Banner.test.tsx Co-authored-by: Kate Higa <[email protected]> * Update packages/react/src/Banner/Banner.test.tsx Co-authored-by: Kate Higa <[email protected]> * test: update test label with aria-label --------- Co-authored-by: Josh Black <[email protected]> Co-authored-by: Kate Higa <[email protected]> * chore(deps-dev): bump cross-env from 7.0.2 to 7.0.3 (#4561) Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 7.0.2 to 7.0.3. - [Release notes](https://github.com/kentcdodds/cross-env/releases) - [Changelog](https://github.com/kentcdodds/cross-env/blob/master/CHANGELOG.md) - [Commits](kentcdodds/cross-env@v7.0.2...v7.0.3) --- updated-dependencies: - dependency-name: cross-env dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @babel/plugin-transform-modules-commonjs (#4562) Bumps [@babel/plugin-transform-modules-commonjs](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-modules-commonjs) from 7.23.3 to 7.24.1. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.1/packages/babel-plugin-transform-modules-commonjs) --- updated-dependencies: - dependency-name: "@babel/plugin-transform-modules-commonjs" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump jest-fail-on-console from 3.1.1 to 3.2.0 (#4563) Bumps [jest-fail-on-console](https://github.com/ValentinH/jest-fail-on-console) from 3.1.1 to 3.2.0. - [Release notes](https://github.com/ValentinH/jest-fail-on-console/releases) - [Commits](ValentinH/jest-fail-on-console@v3.1.1...v3.2.0) --- updated-dependencies: - dependency-name: jest-fail-on-console dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(FeatureFlags): broaden feature flag type to accept undefined (#4554) * feat(FeatureFlags): loosen feature flag type to accept undefined * chore: add changeset * Update .changeset/grumpy-coats-worry.md --------- Co-authored-by: Josh Black <[email protected]> * prevent form submit (#4551) * deprecate title prop on ActionList.Group component on docs (#4544) * chore: add hydro analytics to storybook (#4558) * chore: add hydro analytics to storybook * chore: use previewHead over managerHead * Update build-docs --------- Co-authored-by: Josh Black <[email protected]> * Revert "Revert "Add support for nested submenus to `ActionMenu`"" (#4486) * Revert "Revert "Add support for nested submenus to `ActionMenu` (#4386)" (#4472)" This reverts commit 82072eb. * just want a change to trigger rebuild --------- Co-authored-by: Siddharth Kshetrapal <[email protected]> Co-authored-by: Pavithra Kodmad <[email protected]> * chore(deps): update typescript to 5.4.5 (#4568) Co-authored-by: Josh Black <[email protected]> * Use dynamic height and width for dialogs (#4567) * Use dynamic height and width for dialogs * Update tall-forks-bathe.md --------- Co-authored-by: Siddharth Kshetrapal <[email protected]> * Make asterisk default, update story scenarios * Update packages/react/src/FormControl/FormControl.docs.json Co-authored-by: Owen Niblock <[email protected]> * Update packages/react/src/internal/components/InputLabel.tsx Co-authored-by: Owen Niblock <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lukas Oppermann <[email protected]> Co-authored-by: Siddharth Kshetrapal <[email protected]> Co-authored-by: lukasoppermann <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: Kate Higa <[email protected]> Co-authored-by: Armağan <[email protected]> Co-authored-by: Ian Sanders <[email protected]> Co-authored-by: Pavithra Kodmad <[email protected]> Co-authored-by: Dusty Greif <[email protected]> Co-authored-by: Owen Niblock <[email protected]>

joshblack added 2 commits May 2, 2024 16:52

feat(FeatureFlags): loosen feature flag type to accept undefined

c2f5cc9

chore: add changeset

6199dbf

joshblack requested a review from a team as a code owner May 2, 2024 21:55

joshblack requested a review from TylerJDev May 2, 2024 21:55

joshblack temporarily deployed to github-pages May 2, 2024 21:58 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-4554 May 2, 2024 21:59 Inactive

siddharthkp reviewed May 3, 2024

View reviewed changes

siddharthkp approved these changes May 3, 2024

View reviewed changes

joshblack commented May 3, 2024

View reviewed changes

.changeset/grumpy-coats-worry.md Outdated Show resolved Hide resolved

Update .changeset/grumpy-coats-worry.md

1bfb3ac

joshblack deployed to github-pages May 3, 2024 13:52 — with GitHub Actions View deployment

github-actions bot deployed to storybook-preview-4554 May 3, 2024 13:52 View deployment

joshblack changed the title ~~feat(FeatureFlags): loosen feature flag type to accept undefined~~ feat(FeatureFlags): broaden feature flag type to accept undefined May 3, 2024

joshblack added this pull request to the merge queue May 6, 2024

Merged via the queue into main with commit ed31476 May 6, 2024

joshblack deleted the feat/loosen-feature-flag-types branch May 6, 2024 16:10

primer bot mentioned this pull request May 6, 2024

Release tracking #4559

Merged

This was referenced Jun 11, 2024

[Snyk] Upgrade @primer/react from 36.18.0 to 36.19.0 JonathanXDR/Atom#27

Closed

[Snyk] Upgrade @primer/react from 36.18.0 to 36.19.1 JonathanXDR/Atom#29

Closed

This was referenced Jun 20, 2024

[Snyk] Upgrade @primer/react from 36.18.0 to 36.19.1 JonathanXDR/Atom#30

Closed

[Snyk] Upgrade @primer/react from 36.18.0 to 36.20.0 JonathanXDR/Atom#31

Closed

StemmlerSisters mentioned this pull request Jul 16, 2024

[Snyk] Upgrade @primer/react from 36.1.0 to 36.23.0 StemmlerSisters/documentation#5

Open

snyk-io bot mentioned this pull request Jul 17, 2024

[Snyk] Upgrade @primer/react from 36.11.0 to 36.23.0 Hawthorne001/documentation.npm#3

Open

julitabarelkowska mentioned this pull request Jul 17, 2024

[Snyk] Upgrade @primer/react from 36.11.0 to 36.23.0 julitabarelkowska/documentation#7

Open

Canadatechmanufacturing mentioned this pull request Jul 17, 2024

[Snyk] Upgrade @primer/react from 36.7.0 to 36.23.0 Canadatechmanufacturing/documentation#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(FeatureFlags): broaden feature flag type to accept undefined #4554

feat(FeatureFlags): broaden feature flag type to accept undefined #4554

Uh oh!

joshblack commented May 2, 2024

Uh oh!

changeset-bot bot commented May 2, 2024 •

edited

Loading

Uh oh!

github-actions bot commented May 2, 2024 •

edited

Loading

Uh oh!

siddharthkp May 3, 2024

Uh oh!

joshblack May 3, 2024

Uh oh!

siddharthkp left a comment

Uh oh!

Uh oh!

Uh oh!

feat(FeatureFlags): broaden feature flag type to accept undefined #4554

feat(FeatureFlags): broaden feature flag type to accept undefined #4554

Uh oh!

Conversation

joshblack commented May 2, 2024

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Uh oh!

changeset-bot bot commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented May 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

siddharthkp May 3, 2024

Choose a reason for hiding this comment

Uh oh!

joshblack May 3, 2024

Choose a reason for hiding this comment

Uh oh!

siddharthkp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented May 2, 2024 •

edited

Loading

github-actions bot commented May 2, 2024 •

edited

Loading