-
Notifications
You must be signed in to change notification settings - Fork 638
ActionBar: Add stories for couple of edge cases #4424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 59b943a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticing that this PR in addition to adding stories, also moves the overflow to an ActionMenu.
Is that intentional? If yes, do we need a changeset for that?
Thanks for the review! I should not have made the assumption that draft components don't need changesets. |
I see! If it's not used anywhere yet, then I'd say it's nice to have a changeset but optional for now.
patch/minor sounds good in this case :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it!
Closes #https://github.com/github/primer/issues/3133 and #https://github.com/github/primer/issues/3134
Changelog
Adding two stories for issues that were a problem with the webcomponent in the rails version of this component.