feat(SelectPanel): add support for announcements to SelectPanel.Loading #4407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6f0558a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
approved these changes
Mar 19, 2024
| const SelectPanelLoading = ({children = 'Fetching items...'}: React.PropsWithChildren) => { | ||
| return ( | ||
| <Box | ||
| <Status |
Co-authored-by: Siddharth Kshetrapal <[email protected]>
…-to-select-panel-loading
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
…ng (#4407) * feat(SelectPanel): add support for announcements to SelectPanel.Loading * chore: add changeset * chore: run format * Update .changeset/rare-moose-destroy.md Co-authored-by: Siddharth Kshetrapal <[email protected]> --------- Co-authored-by: Josh Black <[email protected]> Co-authored-by: Siddharth Kshetrapal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/github/primer/issues/3104
Add support for live region announcements to
SelectPanel.LoadingChangelog
New
SelectPanel.LoadingChanged
SelectPanel.Loadingto have optional childrenStatushelperRemoved
Rollout strategy
Testing & Reviewing
SelectPanel.Loadingannounce the given (or default) loading message