Skip to content

Conversation

langermank
Copy link
Contributor

Closes #4367

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@langermank langermank requested a review from a team as a code owner March 14, 2024 16:05
@langermank langermank requested a review from TylerJDev March 14, 2024 16:05
Copy link

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: d72c78d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 14, 2024
Copy link
Contributor

github-actions bot commented Mar 14, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.59 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 88.84 KB (-0.17% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4392 March 14, 2024 16:09 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 14, 2024
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we don't have any visual snapshot tests for NavList but the storybook preview looks good! Ship it :shipit:

@siddharthkp siddharthkp added skip changeset This change does not need a changelog and removed skip changeset This change does not need a changelog labels Mar 14, 2024
@siddharthkp
Copy link
Member

@langermank Hi! I'll leave the decision of adding a changelog or not to you.

FYI, merging to main is temporarily disabled

@github-actions github-actions bot temporarily deployed to storybook-preview-4392 March 14, 2024 16:26 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4392 March 19, 2024 15:29 Inactive
@langermank langermank enabled auto-merge March 22, 2024 19:25
@github-actions github-actions bot temporarily deployed to storybook-preview-4392 March 22, 2024 19:31 Inactive
@langermank langermank deleted the fix-navlist-active-bold branch March 22, 2024 22:13
@primer primer bot mentioned this pull request Mar 22, 2024
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
* make bold

* Create wicked-rings-lay.md

* snaps

---------

Co-authored-by: Josh Black <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NavList.Item active state should show up as bold, but doesn't.
4 participants