get ActionBar axe clean #4388
Merged
get ActionBar axe clean #4388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8bdbb17 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Mar 13, 2024
size-limit report 📦
|
owenniblock
approved these changes
Mar 14, 2024
| <ActionBarContext.Provider value={{size, setChildrenWidth}}> | ||
| <Box ref={navRef} sx={getNavStyles()}> | ||
| <NavigationList sx={ulStyles} ref={listRef} role="list"> | ||
| <NavigationList sx={listStyles} ref={listRef} role="toolbar"> |
There was a problem hiding this comment.
Nice, toolbar makes total sense here. I tested the arrow focusing and it looks fine to me 👍
joshblack
reviewed
Mar 14, 2024
Comment on lines
+30
to
+34
| it('should have no axe violations', async () => { | ||
| const {container} = HTMLRender(<SimpleActionBar />) | ||
| const results = await axe(container) | ||
| expect(results).toHaveNoViolations() | ||
| }) |
There was a problem hiding this comment.
Just wanted to share that axe is also available in the e2e tests but with the additional github rules if that's of interest! Wasn't sure how obvious it was.
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* get ActionBar axe clean * changeset * fix type * fix type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4387
Changelog
New
Changed
ActionBar is now
role=toolbar, and produces valid HTML.Removed
Rollout strategy
Testing & Reviewing
Merge checklist