Skip to content

Remove redundant aria-label attribute from TextInput.Action #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Remove redundant aria-label attribute from TextInput.Action #4354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2255ddf
remove aria-label attribute from TextInput.Action
siddharthkp Mar 5, 2024
a74b353
update snapshot
siddharthkp Mar 5, 2024
219d9ed
Create mighty-pears-deny.md
siddharthkp Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/mighty-pears-deny.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

TextInput: Remove redundant `aria-label` attribute from `TextInput.Action` when it already has an `aria-labelledby`.
1 change: 0 additions & 1 deletion packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2177,7 +2177,6 @@ exports[`TextInput renders trailingAction icon button 1`] = `
className="c3 TextInput-action"
>
<button
aria-label="Icon label"
aria-labelledby=":r1:"
className="c4"
data-block={null}
Expand Down
13 changes: 2 additions & 11 deletions packages/react/src/internal/components/TextInputInnerAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,8 @@ const TextInputAction = forwardRef<HTMLButtonElement, TextInputActionProps>(
<Box as="span" className="TextInput-action" marginLeft={1} marginRight={1} lineHeight="0">
{icon && !children ? (
<Tooltip direction={tooltipDirection ?? 's'} text={ariaLabel ?? ''} type="label">
<IconButton
variant={variant}
type="button"
icon={icon}
size="small"
sx={sx}
{...rest}
aria-label={ariaLabel as unknown as string}
aria-labelledby={undefined}
ref={forwardedRef}
/>
{/* @ts-ignore we intentionally do add aria-label to IconButton because Tooltip v2 adds an aria-labelledby instead. */}
<IconButton variant={variant} type="button" icon={icon} size="small" sx={sx} {...rest} ref={forwardedRef} />
</Tooltip>
) : (
<ConditionalTooltip aria-label={ariaLabel}>
Expand Down