Focus-visible ActionMenu link fix
#4334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 76a404b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
pksjce
approved these changes
Mar 4, 2024
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Switch selector to class, add to ActionMenu example * Account for HCM focus-visible style * Add changeset * Update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix continues from #4166, but changes the selector for links to target the class instead of
:focus-visiblepseudo selector. This is because, if the input modality isn't already keyboard in Safari,:focus-visiblestyles may not be applied, so we need to rely on our.focus-visiblefor now.Changelog
Changed
a:focus-visibletoa.focus-visible)ActionMenuStorybook exampleRollout strategy
Testing & Reviewing
Merge checklist