Skip to content

ActionList: Prevent scroll when an item is selected with Space #4259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 13, 2024
Merged

ActionList: Prevent scroll when an item is selected with Space #4259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
85d8152
prevent default on Space
siddharthkp Feb 12, 2024
e7cd953
immediately reset defaultPrevented
siddharthkp Feb 13, 2024
496ad4f
improve comment
siddharthkp Feb 13, 2024
6328190
Create slow-owls-report.md
siddharthkp Feb 13, 2024
85e4290
Merge branch 'main' into actionlist-avoid-scroll-on-selection
siddharthkp Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slow-owls-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

ActionList: Prevent scroll when an item is selected with `Space`
6 changes: 6 additions & 0 deletions packages/react/src/ActionList/Item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,12 @@ export const Item = React.forwardRef<HTMLLIElement, ActionListItemProps>(
(event: React.KeyboardEvent<HTMLLIElement>) => {
if (disabled || inactive) return
if ([' ', 'Enter'].includes(event.key)) {
if (event.key === ' ') {
event.preventDefault() // prevent scrolling on Space
// immediately reset defaultPrevented once it's job is done
// so as to not disturb the functions that use that event after this
event.defaultPrevented = false
}
onSelect(event, afterSelect)
}
},
Expand Down