Skip to content

Conversation

@broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Feb 9, 2024

This reverts commit 3acbd80.

There is a flaky situation on the new Button group VRT tests - you can checkout the artefacts build in this run: https://github.com/primer/react/actions/runs/7824236577,

It looks like there's an extra px sometimes, in some themes. I'd like to revert this and address it properly.

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2024

⚠️ No Changeset found

Latest commit: 7d51643

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 113.38 KB (-0.05% 🔽)
packages/react/dist/browser.umd.js 114.03 KB (-0.05% 🔽)

Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized I don't have review rights anymore 😦 sorry!

@broccolinisoup broccolinisoup added this pull request to the merge queue Feb 11, 2024
Merged via the queue into main with commit 64b722c Feb 11, 2024
@broccolinisoup broccolinisoup deleted the revert-button-group branch February 11, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants