Skip to content

Dialog v1: Fix title font family #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Dialog v1: Fix title font family #4246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcabbd5
don't need to set fontFamily, inherit it
siddharthkp Feb 9, 2024
fc1a2c1
Create hot-hounds-speak.md
siddharthkp Feb 9, 2024
33f62d8
test(vrt): update snapshots
siddharthkp Feb 9, 2024
104e95e
Merge branch 'main' into dialog-v1-fix-font-family
siddharthkp Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hot-hounds-speak.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Dialog v1: Fix font-family for title
2 changes: 1 addition & 1 deletion packages/react/src/Dialog.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const Default = () => {
<div data-testid="inner">
<Dialog.Header id="header">Title</Dialog.Header>
<Box p={3}>
<Text fontFamily="sans-serif">Some content</Text>
<Text>Some content</Text>
</Box>
</div>
</Dialog>
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/Dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export type DialogHeaderProps = ComponentProps<typeof DialogHeaderBase>
function DialogHeader({theme, children, backgroundColor = 'canvas.subtle', ...rest}: DialogHeaderProps) {
if (React.Children.toArray(children).every(ch => typeof ch === 'string')) {
children = (
<Text theme={theme} color="fg.default" fontSize={1} fontWeight="bold" fontFamily="sans-serif">
<Text fontSize={1} fontWeight="bold">
{children}
</Text>
)
Expand Down