SelectPanel2: Automatically adjust height based on contents #4245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e9bff98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
changed the title
Contributor
size-limit report 📦
|
joshblack
approved these changes
Feb 9, 2024
broccolinisoup
approved these changes
Feb 11, 2024
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* replace height with maxHeight * adjust height of loading & message based on container * remove redundant height from stories * Create strange-starfishes-work.md * fix bad merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was under the false impression that SelectPanel should retain it's height, but we do want it to resize with contents!
Before:
selectpanel-static.mov
After:
selectpanel-auto-resize.mov