refactor(react): remove circular dependencies

[joshblack]

This PR removes circular dependencies that we have in @primer/react. It also updates our rollup config to throw an error when we encounter one when bundling. Circular dependencies in an ESM context create issues where you are unable to use an imported identifier because it has not been defined in the module context yet.

Changelog

New

Changed

• Update imports that point directly to src/index.ts and replaced them with imports directly to the module
• Update cycles by moving shared code into a shared file, either an existing one or by creating a new one

Removed

Rollout strategy

• Minor release

Technically this should be a refactor and no behavior should change but, just to be safe, I think this should go out under a minor release to make sure

Testing & Reviewing

• Verify that the refactor doesn't break any references or functionality 😅

[changeset-bot]

🦋 Changeset detected

Latest commit: 3335d86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	113 KB (-0.01% 🔽)
packages/react/dist/browser.umd.js	113.66 KB (-0.01% 🔽)

[broccolinisoup]

This is great! Thanks so much for taking care of this ✨