Improve aria-labels for example icon buttons and add guidance #4191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenniblock
added
docs
|
Contributor
size-limit report 📦
|
joshblack
added
the
update snapshots
github-actions
bot
removed
the
update snapshots
Contributor
Author
|
Thanks for sorting out the snapshots @joshblack! |
pksjce
pushed a commit
that referenced
this pull request
Feb 8, 2024
* Improve aria-labels for example icon buttons and add guidance * test(vrt): update snapshots --------- Co-authored-by: joshblack <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2024
* Tentative focus fix in action list item * Update snapshots * Create purple-bees-warn.md * chore(deps-dev): bump @babel/cli from 7.22.10 to 7.23.9 (#4189) Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.22.10 to 7.23.9. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.9/packages/babel-cli) --- updated-dependencies: - dependency-name: "@babel/cli" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump terser from 5.17.6 to 5.27.0 (#4187) Bumps [terser](https://github.com/terser/terser) from 5.17.6 to 5.27.0. - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](terser/terser@v5.17.6...v5.27.0) --- updated-dependencies: - dependency-name: terser dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): bump @storybook/source-loader from 7.6.7 to 7.6.10 (#4186) Bumps [@storybook/source-loader](https://github.com/storybookjs/storybook/tree/HEAD/code/lib/source-loader) from 7.6.7 to 7.6.10. - [Release notes](https://github.com/storybookjs/storybook/releases) - [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md) - [Commits](https://github.com/storybookjs/storybook/commits/v7.6.10/code/lib/source-loader) --- updated-dependencies: - dependency-name: "@storybook/source-loader" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Improve aria-labels for example icon buttons and add guidance (#4191) * Improve aria-labels for example icon buttons and add guidance * test(vrt): update snapshots --------- Co-authored-by: joshblack <[email protected]> * chore(deps): bump @github/combobox-nav from 2.1.7 to 2.3.1 (#4185) * chore(deps): bump @github/combobox-nav from 2.1.7 to 2.3.1 Bumps [@github/combobox-nav](https://github.com/github/combobox-nav) from 2.1.7 to 2.3.1. - [Release notes](https://github.com/github/combobox-nav/releases) - [Commits](github/combobox-nav@v2.1.7...v2.3.1) --- updated-dependencies: - dependency-name: "@github/combobox-nav" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * test: add fallback for Element#scrollIntoView * chore: fix eslint warning --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <[email protected]> * Add missing CSS vars to legacy-theme (#4193) * oof * Create thirty-mirrors-switch.md * test(vrt): update snapshots * fix missing var * fix parens * test(vrt): update snapshots --------- Co-authored-by: langermank <[email protected]> * Version Packages (#4183) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Owen Niblock <[email protected]> Co-authored-by: joshblack <[email protected]> Co-authored-by: Katie Langerman <[email protected]> Co-authored-by: langermank <[email protected]> Co-authored-by: primer[bot] <119360173+primer[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/2181
Changes the aria-labels on examples so they are more realistic and better describe the icon button itself. I figured the "Close" button used as the default for the Playground might be a bit confusing so I changed this to "Favorite".
I also updated the docs to include the
aria-labelproperty and linked to the help docs on primer.style. Please note that I included the full URL, if there's a better way to add this reference please let me know.Changelog
New
Changed
Removed
Rollout strategy
This is a docs change and so I don't believe it requires a version release (please correct me if I'm wrong!)
Testing & Reviewing
Run the storybook & docs site locally to test. Changes can be seen:
Merge checklist