-
Notifications
You must be signed in to change notification settings - Fork 638
Dialog: Full screen & Bottom sheet support #4180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing in favor of the followup PRs we've merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Pull Request: #4048
Closes https://github.com/github/primer/issues/2414
Closes https://github.com/github/primer/issues/2413
Note: I've chosen not to tackle the issues mentioned here to avoid causing any disruptive changes.
Changelog
New
1️⃣
action-sheet
dialogWe've implemented a range slider to easily adjust the size of the dialog using only a keyboard, enhancing accessibility. We've used a similar approach for our SplitPageLayout resizer. I've also implemented reduced-motion support.
Screen.Recording.2023-12-12.at.17.14.30.mov
keyboard.mov
2️⃣
full-screen
dialogThis is quite simple, as it closely resembles the existing dialog behavior, with the only difference being that it's full-screen.
Screen.Recording.2023-12-12.at.17.15.47.mov
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist