Skip to content

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Jan 24, 2024

Previous Pull Request: #4048

Closes https://github.com/github/primer/issues/2414
Closes https://github.com/github/primer/issues/2413

Note: I've chosen not to tackle the issues mentioned here to avoid causing any disruptive changes.

Changelog

New

1️⃣ action-sheet dialog

We've implemented a range slider to easily adjust the size of the dialog using only a keyboard, enhancing accessibility. We've used a similar approach for our SplitPageLayout resizer. I've also implemented reduced-motion support.

Screen.Recording.2023-12-12.at.17.14.30.mov
keyboard.mov

2️⃣ full-screen dialog

This is quite simple, as it closely resembles the existing dialog behavior, with the only difference being that it's full-screen.

Screen.Recording.2023-12-12.at.17.15.47.mov

Changed

  • Storybook features always display dialogs in an open state so that snapshots can effectively capture any changes.
  • Removed the ability to change props in features for simplicity and consistency with other components
  • In the example called 'WithCustomRenderers', I've placed the header, content, and footer components inside the 'WithCustomRenderers' component. This change improves readability, especially when highlighting the code.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@github-actions github-actions bot temporarily deployed to storybook-preview-4180 February 15, 2024 23:35 Inactive
@maximedegreve maximedegreve added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Feb 15, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4180 February 20, 2024 14:44 Inactive
@maximedegreve maximedegreve added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Feb 20, 2024
@langermank
Copy link
Contributor

Closing in favor of the followup PRs we've merged

@langermank langermank closed this Apr 11, 2024
@jonrohan jonrohan deleted the feature/full-screen-clean-2 branch May 9, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants