Skip to content

Conversation

@iansan5653
Copy link
Contributor

@iansan5653 iansan5653 commented Jan 19, 2024

Closes #3604

Removes the MarkdownEditor and related components and hooks. I also reviewed our dependencies and removed any that were only used by this code. Not much to say here - it was mostly just deleting everything and running npm i.

Changelog

Removed

Deprecated experimental components and hooks:

  • MarkdownEditor
  • MarkdownViewer
  • InlineAutocomplete
  • useCombobox
  • useDynamicTextareaHeight
  • useIgnoreKeyboardActionsWhileComposing
  • useSafeAsyncCallback
  • useSyntheticChange
  • useUnifiedFileSelect

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Rollout for GitHub will be straightforward for this change as all internal code has already migrated to the internal versions of these components and hooks.

Note

Although this is all experimental code and we can delete it at any time since experimental code doesn't follow semver, I think it's more polite to any downstream consumers to delete this in a major version, giving this change more visibility. There's no rush to make this change as the code is already deprecated, so we can hold off merging this until we're ready to make another major bump (or we can merge to a release branch if we have one).

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Added/updated previews (Storybook)
  • Changes are SSR compatible
  • NA: [ ] Tested in Chrome
  • NA: [ ] Tested in Firefox
  • NA: [ ] Tested in Safari
  • NA: [ ] Tested in Edge
  • (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

@iansan5653 iansan5653 requested review from a team and broccolinisoup January 19, 2024 16:00
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: 32d4761

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iansan5653 iansan5653 self-assigned this Jan 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jan 19, 2024

size-limit report 📦

Path Size
dist/browser.esm.js 105.97 KB (0%)
dist/browser.umd.js 106.66 KB (0%)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing this PR @iansan5653 - I'll refrain from approving to make sure it doesn't get merged accidentally. Let me know if you have any concern.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2024

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove MarkdownEditor from @primer/react

3 participants