-
Notifications
You must be signed in to change notification settings - Fork 645
Remove MarkdownEditor and related code
#4160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 32d4761 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
8d3fb4c to
c7547c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing this PR @iansan5653 - I'll refrain from approving to make sure it doesn't get merged accidentally. Let me know if you have any concern.
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
Closes #3604
Removes the
MarkdownEditorand related components and hooks. I also reviewed our dependencies and removed any that were only used by this code. Not much to say here - it was mostly just deleting everything and runningnpm i.Changelog
Removed
Deprecated experimental components and hooks:
MarkdownEditorMarkdownViewerInlineAutocompleteuseComboboxuseDynamicTextareaHeightuseIgnoreKeyboardActionsWhileComposinguseSafeAsyncCallbackuseSyntheticChangeuseUnifiedFileSelectRollout strategy
Rollout for GitHub will be straightforward for this change as all internal code has already migrated to the internal versions of these components and hooks.
Note
Although this is all experimental code and we can delete it at any time since experimental code doesn't follow semver, I think it's more polite to any downstream consumers to delete this in a major version, giving this change more visibility. There's no rush to make this change as the code is already deprecated, so we can hold off merging this until we're ready to make another major bump (or we can merge to a release branch if we have one).
Merge checklist
[ ] Tested in Chrome[ ] Tested in Firefox[ ] Tested in Safari[ ] Tested in Edge