Skip to content

SelectPanel2: Only show clear action in search with text #4146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 23, 2024
Merged

SelectPanel2: Only show clear action in search with text #4146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eafa432
Only show clear action in search with text
siddharthkp Jan 13, 2024
d95c1d7
tiny cleanup
siddharthkp Jan 22, 2024
c59614a
Create bright-dolphins-kick.md
siddharthkp Jan 22, 2024
b7c895a
Merge branch 'main' into drafts-selectpanel-clear-action
siddharthkp Jan 22, 2024
56aaee9
Update bright-dolphins-kick.md
siddharthkp Jan 22, 2024
8ab9f66
Update warm-actors-jam.md
siddharthkp Jan 22, 2024
b347d32
Merge branch 'main' into drafts-selectpanel-clear-action
siddharthkp Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bright-dolphins-kick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

experimental/SelectPanel: Clear action in search input is only visible when there is text to clear
7 changes: 1 addition & 6 deletions src/drafts/SelectPanel2/SelectPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,12 +406,7 @@ const SelectPanelSearchInput: React.FC<TextInputProps> = ({onChange: propsOnChan
}}
/>
}
sx={
{
/* TODO: uncommenting this breaks keyboard navigation, that's odd */
// '& input:empty + .TextInput-action': {display: 'none'},
}
}
sx={{'&:has(input:placeholder-shown) .TextInput-action': {display: 'none'}}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was fun! was able to use a new css feature and a really old css feature

onChange={internalOnChange}
{...props}
/>
Expand Down