Fix missing selection attributes in ActionList items #4096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dc1ea48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
strackoverflow
temporarily deployed
to
github-pages
GitHub Actions
Inactive
strackoverflow
temporarily deployed
to
github-pages
GitHub Actions
Inactive
strackoverflow
temporarily deployed
to
github-pages
GitHub Actions
Inactive
strackoverflow
commented
Dec 20, 2023
| > | ||
| <li | ||
| aria-labelledby="0--label " | ||
| aria-selected={false} |
Member
Author
There was a problem hiding this comment.
It looks like Autocomplete might have had a similar issue with list items not having aria-selected attributes, and this fix applies here as well.
joshblack
approved these changes
Dec 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following a11y audit issue: https://github.com/github/accessibility-audits/issues/4484 (GitHub staff only)
This PR fixes an accessibility issue with
ActionListitems not reporting their selection state to screen readers.The
aria-selected(oraria-checked) attributes were not being applied toActionList.Itembecause they were only being read fromActionListContainerContext, butActionListinstances don't provide that context.The solution I chose here was to automatically infer the selection attribute type based on the item's role:
menuitemcheckboxandmenuitemradioroles get an inferred selection attribute ofaria-checked, whileoptionroles will getaria-selected.Of course, if a selection attribute is specified through
ActionListContainerContext, that will be preferred.Interestingly, selection state was asserted in one of the component tests, but the
aria-selectedattribute was manually provided in the test stub. Removing that allows the test to assert the actual selection behavior.Demo
This screenshot demonstrates the NVDA screenreader properly announcing the selection state with this change:
Rollout strategy
Testing & Reviewing
Merge checklist