-
Notifications
You must be signed in to change notification settings - Fork 645
Add animated prop to ProgressBar
#4061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: aa8c0c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great ✨
| width: ${props => (props.progress ? `${props.progress}%` : 0)}; | ||
| background-color: ${get('colors.success.emphasis')}; | ||
| @media (prefers-reduced-motion: no-preference) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this 💖
Relates to https://github.com/github/primer/issues/2683
Changelog
New
animatedprop onProgressBarChanged
Removed
Rollout strategy
Testing & Reviewing
Merge checklist