Skip to content

Conversation

@mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Dec 6, 2023

This fixes a regression where loading cells were collapsing. This PR appears to be what introduced the regression.

Before:
Screenshot 2023-12-06 at 10 29 01 AM

After:
Screenshot 2023-12-06 at 10 28 53 AM

Closes #

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and siddharthkp December 6, 2023 15:34
@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 61a7b9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.69 KB (0%)
dist/browser.umd.js 105.19 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4026 December 6, 2023 15:39 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Uh oh! @mperrotti, the image you shared is missing helpful alt text. Check your pull request body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@mperrotti mperrotti added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 503c7e6 Dec 6, 2023
@mperrotti mperrotti deleted the mp/loading-table-layout-fix branch December 6, 2023 16:12
@primer primer bot mentioned this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants