Skip to content

Allow modal dialogs in useRovingTabIndex #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2023
Merged

Allow modal dialogs in useRovingTabIndex #4013

merged 2 commits into from
Dec 6, 2023

Conversation

@keithamus
Copy link
Contributor

@keithamus keithamus commented Dec 4, 2023 •
edited
Loading

Closes #4015

Changelog

New

Changed

Avoid error when using Modal Dialog within TreeView

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: abe0e19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 104.67 KB (+0.04% 🔺)
dist/browser.umd.js 105.21 KB (+0.03% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4013 December 4, 2023 16:51 Inactive
@keithamus keithamus force-pushed the skip-top-layer-elements-in-userovingtabindex branch from 1897689 to d9448d7 Compare December 4, 2023 17:00
@github-actions github-actions bot temporarily deployed to storybook-preview-4013 December 4, 2023 17:06 Inactive
@keithamus keithamus force-pushed the skip-top-layer-elements-in-userovingtabindex branch from d9448d7 to 20e5c08 Compare December 4, 2023 17:06
@keithamus keithamus force-pushed the skip-top-layer-elements-in-userovingtabindex branch from 20e5c08 to f0e3ad4 Compare December 4, 2023 17:06
@github-actions github-actions bot temporarily deployed to storybook-preview-4013 December 4, 2023 17:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4013 December 4, 2023 17:11 Inactive
@keithamus keithamus changed the title skip top layer elements in useRovingTabIndex Allow modal dialogs in useRovingTabIndex Dec 4, 2023
@keithamus keithamus marked this pull request as ready for review December 4, 2023 17:32
@keithamus keithamus requested review from a team and pksjce December 4, 2023 17:32
@keithamus keithamus mentioned this pull request Dec 4, 2023
Closed
siddharthkp
siddharthkp approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Safe change, LGTM!

@keithamus keithamus added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit d26aeab Dec 6, 2023
@keithamus keithamus deleted the skip-top-layer-elements-in-userovingtabindex branch December 6, 2023 16:07
@primer primer bot mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

@pksjce pksjce Awaiting requested review from pksjce

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Putting a modal dialog in TreeView causes a crash.

3 participants

@keithamus @siddharthkp