Skip to content

Conversation

@dipree
Copy link
Contributor

@dipree dipree commented Dec 4, 2023

The changes in #3965 have been rolled back because of #3997.

This PR has the same changes as before plus it adds the missing outline overwrite for the MarkdownEditor.

Changelog

  • Changes the focus styling of input components such as Textarea, TextInput, TextInputWithTokens from using border and box-shadow to only use outline

Changed

  • Avoid potential scrollbars overlapping the border of the Textarea component
  • Remove border radius fragments of Textarea, TextInput, TextInputWithTokens and Select component when focused
  • Retain the box-shadow inset on focus
  • Avoid text overlapping the 1px box-shadow inset on focus when scrolling

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: a9b9f5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.55 KB (+0.01% 🔺)
dist/browser.umd.js 105.1 KB (+0.02% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4008 December 4, 2023 08:24 Inactive
@dipree dipree added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit df7dc2a Dec 4, 2023
@dipree dipree deleted the dipree/textarea-input-focus-updates branch December 4, 2023 18:04
@primer primer bot mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants