Add stories to show Tooltip and Dialog usage in Inactive Buttons

[pksjce]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6ad028f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	104.68 KB (0%)
dist/browser.umd.js	105.21 KB (0%)

[mperrotti]

I'm not sure if we need to duplicate Tooltip and Dialog stories just for inactive buttons. I like that the button stories focus specifically on button functionality.

We have these stories to show how to use Tooltip and Dialog:

• https://primer.style/react/storybook/?path=/story/drafts-components-tooltip--default
• https://primer-1bba60ffcd-13348165.drafts.github.io/storybook/?path=/story/components-dialog--default

That being said, I'm not strongly opposed to adding additional example stories for Button. If folks would find this helpful, we can definitely merge this after #3812.

[langermank]

@pksjce I'm not sure if these stories are meant to show a tooltip and dialog but nothing happens for me when I hover/click 🤔

Maybe we should create a separate section of Storybook just to showcase degraded experiences? Or, maybe the internal Storybook would be a better place for this.

[pksjce]

@mperrotti - I don't think there is any harm showcasing specific expectations for the inactive button.
Also as @langermank pointed out, I can't get the dialog and tooltip to work with this implementation. Since this is on top of your PR, I was hoping you'd have a fix off the top of your mind? Else I'm planning on debugging this and making sure it works.
I also wanted to highlight that adding a tooltip optionally is a little awkward and if devs who were working on gracefully degrading using the inactive button had questions, we could point them to this little implementation.

[pksjce]

Closing this as we will update stories for these use cases if questions etc arise on usage of inactive component states.