Skip to content

deprecate title prop and throw warning #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

deprecate title prop and throw warning #3984

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cbd7bb
deprecate title prop and throw warning
broccolinisoup Nov 29, 2023
5a1d2ef
only warn for list role use
broccolinisoup Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ActionList/Group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export type ActionListGroupProps = {
*/
variant?: 'subtle' | 'filled'
/**
* Primary text which names a `Group`.
* @deprecated('Use `ActionList.GroupHeading` instead')
*/
title?: string
/**
Expand Down Expand Up @@ -71,6 +71,11 @@ export const Group: React.FC<React.PropsWithChildren<ActionListGroupProps>> = ({
groupHeadingId = id
}

warning(
title && listRole === undefined,
'title prop is deprecated in ActionList.Group. Please use ActionList.GroupHeading instead for improved semantics',
)

return (
<Box
as="li"
Expand Down