Skip to content

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented Nov 28, 2023

Changelog

Adjusts order of PageLayout.Pane so that the resizable widget is always after the Pane content.

Changed

  • Adjusts PageLayout.Pane component order

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan

Testing & Reviewing

Merge checklist

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 73366e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 28, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 104.55 KB (-0.01% 🔽)
dist/browser.umd.js 105.1 KB (0%)

@pksjce
Copy link
Contributor

pksjce commented Nov 29, 2023

This fix seems to work! thanks so much @TylerJDev.
Apologise for the oversight. Maybe you could add some interactive content to the Resizable Pane storybook so we can showcase the problem and its fix in a better manner? Thats what I had to do to test the fix basically.

@github-actions github-actions bot temporarily deployed to storybook-preview-3983 November 29, 2023 16:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3983 November 29, 2023 16:35 Inactive
@TylerJDev TylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 29, 2023
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 29, 2023
@primer primer bot temporarily deployed to github-pages November 29, 2023 18:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3983 November 29, 2023 18:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3983 November 29, 2023 18:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3983 November 29, 2023 18:30 Inactive
@TylerJDev TylerJDev marked this pull request as ready for review November 29, 2023 18:57
@TylerJDev TylerJDev requested review from a team and siddharthkp November 29, 2023 18:57
@github-actions github-actions bot temporarily deployed to storybook-preview-3983 November 29, 2023 19:56 Inactive
@TylerJDev TylerJDev added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 29, 2023
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 29, 2023
@joshblack joshblack added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 43d1dce Nov 29, 2023
@joshblack joshblack deleted the tylerjdev/pagelayout-pane-order-adjust branch November 29, 2023 20:49
@primer primer bot mentioned this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants