refactor(useId): update useId to use React.useId, update ssr utils

[joshblack]

Background for these changes: https://github.com/github/primer/issues/1715#issuecomment-1830411602

Update SSRProvider, useSSRSafeId to use the native React 18 useId() instead of @react-aria/ssr

Changelog

New

Changed

• Update SSRProvider to noop
• Update useSSRSafeId to use our internal useId
• Update useId to use the native React.useId() hook
• Update snapshots to use new useId generation

Removed

• Remove @react-aria/ssr from the project

Rollout strategy

• Minor release

Hopefully this can be contained in a minor release as the changes should all be compatible 🤞 This PR does end up removing support for @react-aria/ssr and replaces it but we could also keep the dependency in the project and remove it later if it ends up being problematic. This work should definitely be tested out in dotcom to see what the impact is.

Testing & Reviewing

• Would appreciate a look at the type signatures for the changed exports to make sure they are equivalent
• Verify that id generation still works as expected in components which use this hook
• Double-check the rollout plan to see if I missed anything 👀

[changeset-bot]

🦋 Changeset detected

Latest commit: d10aa5f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	104.08 KB (-0.45% 🔽)
dist/browser.umd.js	104.61 KB (-0.46% 🔽)

[broccolinisoup]

TL;DR

Looks beautiful! ✨

Would appreciate a look at the type signatures for the changed exports to make sure they are equivalent

All makes sense to me ✅

Verify that id generation still works as expected in components which use this hook

Checked the Tooltip and UnderlineNav, both are golden ⭐

Double-check the rollout plan to see if I missed anything 👀

Based on https://github.com/github/primer/issues/1715#issuecomment-1830411602, I just wanted to say that I LOVE the migration plan. Great example of how to gradually move from A to B and from B to C 😊

One question about the deprecating the SSRProvider and the useSSRSafeId , should we do it in this PR or a follow up PR is better? Curious to hear your thoughts.

[siddharthkp]

Very nice!